Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the main files of the package #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ZeinabMohammed
Copy link

No description provided.

Copy link
Contributor

@mhaggag mhaggag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the dist folder included in the commit? Isn't it built locally and uploaded to pypi separately?

@@ -0,0 +1 @@
# TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme needs to be updated with an overview of the project, as well as the steps necessary to work on it if any.

@@ -0,0 +1,20 @@
[project]
name = "lava-frappe-sdk"
version = "2.18"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this the version we're starting with?

Comment on lines 3 to 4
class POSException(Exception):
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in input_model_base?

@@ -0,0 +1,93 @@
from __future__ import print_function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed for Python 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants