-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 4.0.0 #988
Merged
release 4.0.0 #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since a lot of people are updating to lavalink v4 from v3 they don't have this setting in their application.yml these logs are an easy way to see if anything is wrong and should be enabled by default
Co-authored-by: Freya Arbjerg <freya@arbjerg.dev>
* Remove forced Xmx on docker entrypoint * Set default readme copypastable Xmx value to 1G * Remove forced Xmx4G from alpine docker file --------- Co-authored-by: Toπ <git@topi.wtf> # Conflicts: # README.md
* allow for deserialization of plugin info into data classes * fix unit test * fixup java access for plugin info deserialization Co-authored-by: viztea <hi@vzt.gay> * rename deserialize to deserializePluginInfo & docs * remove unused import --------- Co-authored-by: viztea <hi@vzt.gay>
* implement track user data * fix unit tests and add Track#copyWithUserData * remove unnecessary exceptionally * use loadItemSync instead of loadItem in player rest handler * Update protocol/src/commonTest/kotlin/PlayerSerializerTest.kt Co-authored-by: Duncan Sterken <contact@duncte123.me> * throw http 400 if both track and encodedTrack/identifier is set * add convenient deserializeUserData method for java --------- Co-authored-by: Duncan Sterken <contact@duncte123.me>
* document track user data * Apply suggestions from code review Co-authored-by: Duncan Sterken <contact@duncte123.me> Co-authored-by: Freya Arbjerg <freya@arbjerg.dev> * readded depreacted fields --------- Co-authored-by: Duncan Sterken <contact@duncte123.me> Co-authored-by: Freya Arbjerg <freya@arbjerg.dev>
# Conflicts: # README.md
Deploying with Cloudflare Pages
|
freyacodes
requested changes
Dec 3, 2023
Co-authored-by: Freya Arbjerg <freya@arbjerg.dev>
freyacodes
approved these changes
Dec 3, 2023
Co-authored-by: Freya Arbjerg <freya@arbjerg.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
/v3
endpoints except/version
. All other endpoints are now under/v4
20
) to jammy(22
)2.0.0-rc2
2.0.4
, which includes native support for artwork urls and ISRCs in the track infoTrack
objects in following events:TrackStartEvent
,TrackEndEvent
,TrackExceptionEvent
,TrackStuckEvent
Session-Id
header instead ofResume-Key
headerx86-64
,aarch64
) based systems (most notablyalpine
)Omissible#isPresent
&Omissible#isOmitted
to theprotocol
modulelavalink.pluginsDir
(defaults to./plugins
)Warning
Lavalink previously set the
-Xmx
flag to4G
in docker. This caused issues with some systems which had less than 4GB of RAM. We have now removed this flag and let the JVM decide the max heap allocation.On how to increase the max heap allocation, see here.