Add isPlaylist to response JSON #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
freyacodes
reviewed
Apr 30, 2018
| @@ -98,3 +103,13 @@ public void loadFailed(FriendlyException e) { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| class LoadResult { | |||
| public List<AudioTrack> tracks; | |||
There was a problem hiding this comment.
Why not make this immutable?
|
This is super useful, can someone be able to merge this PR? |
|
It is planned for v3 because of its breaking changes. See the milestone |
|
Ah, understood. Thanks |
freyacodes
approved these changes
Jun 2, 2018
freyacodes
pushed a commit
to freyacoded/repo-test
that referenced
this pull request
Oct 11, 2022
* Add isPlaylist to response JSON * Unmodifiable list * Expose selectedTrack and playlistName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows clients to identify Search or Playlist results and handle the response accordingly.
This is a breaking change to clients as it modifies the JSON that is returned
Partially fulfills #38