Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.5.1 #34

Merged
merged 11 commits into from
Nov 8, 2022
Merged

Release/v0.5.1 #34

merged 11 commits into from
Nov 8, 2022

Conversation

weidel-p
Copy link
Contributor

@weidel-p weidel-p commented Nov 4, 2022

This PR updates the website to document Lava version 0.5.1 and the corresponding libraries.

Still left to do:

  • Fix formatting issues in lava-optimization. (lava-optimization/src/lava/lib/optimization/solvers/bayesian/solver.py and lava-optimization/src/lava/lib/optimization/solvers/bayesian/solver.py have faulty docstrings)
  • Check if the 'getting started' section is up to date with the current state of the libraries

@bamsumit
Copy link
Contributor

bamsumit commented Nov 4, 2022

I have noticed two things for now:

  • image
    I would suggest red portion to be collapsed as I would expect to get a summary/table of content of the modules here and this gets distracting
  • image
    Latex rendering is broken. This is probably in your setup because I noticed this in your earlier renderings.

@weidel-p
Copy link
Contributor Author

weidel-p commented Nov 4, 2022

I changed the max-depth level to two to comply with @bamsumit request. I also think it's nicer like that. I also added the changes in the current lava-optimization PRs.

The equations will be rendered correctly in CI, just not on the machine I used for preview.

@bamsumit
Copy link
Contributor

bamsumit commented Nov 4, 2022

I changed the max-depth level to two to comply with @bamsumit request. I also think it's nicer like that. I also added the changes in the current lava-optimization PRs.

The equations will be rendered correctly in CI, just not on the machine I used for preview.

I think there is one more level that needs change in max-depth level:
image
Looks like that's only for lava-dl

@weidel-p
Copy link
Contributor Author

weidel-p commented Nov 7, 2022

Oh, sorry, I somehow thought that lava-dl was already formatted correctly. I now reduced the max-depth there, too.

Copy link
Contributor

@bamsumit bamsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good not Philipp. Thanks :)

@weidel-p weidel-p merged commit 2f8d708 into main Nov 8, 2022
@mgkwill mgkwill deleted the release/v0.5.1 branch November 16, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants