Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install #45

Merged
merged 17 commits into from
Mar 9, 2022
Merged

Install #45

merged 17 commits into from
Mar 9, 2022

Conversation

mgkwill
Copy link
Contributor

@mgkwill mgkwill commented Mar 8, 2022

No description provided.

mgkwill and others added 16 commits March 8, 2022 13:49
Drop coverage requirement to 45% as project only has this amount of coverage for now.
Fix python invalid non-printable character U+00A0
Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com>
Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com>
README.md Outdated
$ export PYTHONPATH=$PYTHONPATH:$(pwd)/src
$ pyb -E unit
cd $HOME
git clone git@github.com:lava-dl/lava.git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be lava-dl.git not lava.git but it looks like this has been present for some time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

README.md Show resolved Hide resolved
Copy link
Contributor

@bamsumit bamsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mgkwill mgkwill merged commit 22aa233 into main Mar 9, 2022
@mgkwill mgkwill deleted the install branch March 9, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants