Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing tests/lava/lib/dl/netx/test_hdf5.py #44

Merged
merged 13 commits into from
Mar 8, 2022

Conversation

bamsumit
Copy link
Contributor

@bamsumit bamsumit commented Mar 8, 2022

Issue Number: 43

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • tests/lava/lib/dl/netx/test_hdf5.py fails with lava tip

What is the new behavior?

  • tests/lava/lib/dl/netx/test_hdf5.py passes

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@bamsumit bamsumit linked an issue Mar 8, 2022 that may be closed by this pull request
7 tasks
@mgkwill mgkwill merged commit 70ab5ab into lava-nc:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unittest failing with lava tip
2 participants