-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recurrent netx save and load #324
Conversation
Signed-off-by: Jonathan Timcheck <jonathan.timcheck@intel.com>
…viously for recurrent nets Signed-off-by: Jonathan Timcheck <jonathan.timcheck@intel.com>
Signed-off-by: Jonathan Timcheck <jonathan.timcheck@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timcheck all looks good. Please convert the example to an unittest as discussed.
Signed-off-by: Jonathan Timcheck <jonathan.timcheck@intel.com>
Signed-off-by: Jonathan Timcheck <jonathan.timcheck@intel.com>
Thanks @bamsumit, I converted the example to a unittest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timcheck Looks good to me. Thanks for doing this.
Issue Number: #327
Objective of pull request: As a user, I want to be able to save and load dense recurrent networks from lava-dl into lava.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/
) and (bandit -r src/lava/.
) pass locallypytest
) passes locallyPull request type
Please check your PR type:
What is the current behavior?
Cannot save/load recurrent network with NetX.
What is the new behavior?
A new hdf5 layer category for dense recurrent layers allows saving recurrent networks to an hdf5 file.
NetX can load into Lava a recurrent network from an hdf5 file.
A unit test shows example usage. An example 2-layer 5-neuron dense recurrent network is created in Lava-dl, saved to a hdf5 file, and loaded into Lava from the hdf5 file. The network is run in both Lava-dl and Lava on an example input to confirm matching activity level within an error margin of 2%.
Does this introduce a breaking change?