Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing sign of surrogate gradient for graded spikes #286

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

ccaccavella
Copy link
Contributor

@ccaccavella ccaccavella commented Feb 13, 2024

Issue Number: There is no issue open. The change has been discussed with Sumit Shrestha.

Objective of pull request:
The changes has been made because the implementation of the surrogate gradient in the case of a graded spike activity was wrong. Specifically, the the sign inside the exponential function was reversed.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@ccaccavella ccaccavella changed the title fixing sign of surrogate gradient sign fixing sign of surrogate gradient for graded spikes Feb 13, 2024
Copy link
Contributor

@bamsumit bamsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccaccavella thanks a lot for identifying this and issuing a fix :)

@bamsumit bamsumit merged commit 1fd0647 into lava-nc:main Feb 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants