Paolo gcd branch #193
Merged
Paolo gcd branch #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 10, 2023 12:36
np.argwhere of a torch tensor gives a row vector rather than a column vector as expected
Payload requires slicing with payload[valid_ind] as well
|
Issue 192: #192 |
Runs without exceptions, identical output as when using numpy array input, to_tensor(), and fill_tensor() are tested.
|
@PaoloGCD Thanks for the PR. We appreciate the contribution. It looks good. |
bamsumit
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Objective of pull request:
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
Describe the bug
Two bugs were found in the IO file:
fill_tensor() fails when a "graded" tensor is provided. This is because the payload requires slicing in the same way as the event components were done.
tensor_to_event() fails when a Torch tensor is provided. For some reason, np.argwhere() of a Torch tensor returns a row vector instead of the expected column vector. This can be solved by using torch.argwhere() when a tensor is provided and np.argwhere() when a NumPy array is provided."
What is the new behavior?
fill_tensor() works when graded tensor is provided
tensor_to_event() handles correctly torch tensors as input
Does this introduce a breaking change?
Supplemental information