Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pool layer when pre_hook function is not None #13

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Fix Pool layer when pre_hook function is not None #13

merged 2 commits into from
Nov 24, 2021

Conversation

valmat07
Copy link
Contributor

Correct call of the prehook function on the weights of the pool layer

@mgkwill
Copy link
Contributor

mgkwill commented Nov 24, 2021

Thanks for this request @valmat07. I've added @srrisbud @bamsumit to take a look.

Generally the process is to file an issue and explain in detail before submitting a pull request.

bamsumit
bamsumit approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@bamsumit bamsumit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @valmat07

mgkwill
mgkwill approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@mgkwill mgkwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bamsumit bamsumit merged commit fd695f5 into lava-nc:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgkwill mgkwill mgkwill approved these changes

@bamsumit bamsumit bamsumit approved these changes

@srrisbud srrisbud Awaiting requested review from srrisbud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valmat07 @mgkwill @bamsumit