Chore: Fixes #9678: Fix API and mobile startup regressions caused by folder refactor #9679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aused by folder refactor
personalizedrefrigerator
referenced
this pull request
Jan 7, 2024
personalizedrefrigerator
added a commit
to personalizedrefrigerator/joplin
that referenced
this pull request
Jan 7, 2024
laurent22
reviewed
Jan 7, 2024
| const { ErrorNotFound } = require('../utils/errors'); | ||
|
|
||
| export default async function(request: Request, id: string = null, link: string = null) { | ||
| if (request.method === 'GET' && !id) { | ||
| if (request.query.as_tree) { | ||
| const folders = await FoldersScreenUtils.allForDisplay({ fields: requestFields(request, BaseModel.TYPE_FOLDER) }); | ||
| const folders = await allForDisplay({ fields: requestFields(request, BaseModel.TYPE_FOLDER) }); |
There was a problem hiding this comment.
I don't know how I missed that, thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two regressions related to 7637163 (fixes #9678).
Note:
Chore.Mobile,Clipper,Desktop: Fixes #9678: Fix regressions caused by folder refactor.Testing
This pull request adds an automated test to verify that the API-related change works.
The mobile fix was tested on Android 7 by