Desktop: Performance: fixes false dependencies between MainScreen and UserWebview #6446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ken1kob, I will close these pull requests because even if we do optimise these parts of the code we will follow a different approach, which will probably start by some refactoring. Also I believe some of these performance issue no longer apply due to recent changes. I appreciate anyway you taking the time to look into this, and apologies for not merging these particular PRs. |
This was referenced Nov 19, 2023
Repository owner
locked as resolved and limited conversation to collaborators
Nov 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of PRs resolving issue #6386 and improves various UI responses.
MainScreenComponent has pluginHtmlContents property in its props, but it is needed not by MainScreenComponent itself but by UserWebview and UserWebviewDialog. This false dependency causes redundant re-rendering. Because when pluginHtmlContents property changes, MainScreenComponent is re-rendered, and then its children components (almost all except MenuBar) are also re-rendered.
Treatments in this PR: