Desktop: Load codemirror css in index.html #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok I'm not sure what's causing the bug either so let's keep like this for now then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference
I couldn't pinpoint the exact cause of failure on this one, but it seems like codemirror doesn't like it when the css is lazy loaded. I think there is probably some form of race condition happening while it is initializing.
I figured the simplest solution would be to load the 8.5KB codemirror.css file in index.html. If that is too slow we could probably change this to add only the exact css needed in index.html and lazy load the rest of the file, but I don't think that's really worth the complexity.