Fix issues found by shellcheck - attempt 2 #3652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was identified by [shellcheck](https://www.shellcheck.net/). More information about this particular fix: https://www.shellcheck.net/wiki/SC2006
This issue was identified by [shellcheck](https://www.shellcheck.net/). More information about this particular fix: https://www.shellcheck.net/wiki/SC2236
Fixes behavior where TEMP_DIR is manually changed to point to a different location, for example if /tmp does not have enough space. If this new location contains spaces, the script would break. Issue was identified by [shellcheck](https://www.shellcheck.net/). More information about this fix: https://www.shellcheck.net/wiki/SC2086
|
Sorry but the issue is still the same. I can see there are good fixes in there like quotes around paths, but the truth is I don't want to have to review and check this, especially since the script mostly works. There might be some subtle issues in there too, which will cause more support needed when we release it. We have very limited resources here so when something works we tend to keep it as it is. |
|
Closing due to above reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new version of #3648
I have broken down the fixes into individual commits, with brief explanations and links to resources that explain the reasoning in more detail.
None of the changes affect current behavior of the script. They make the script more consistent with current best coding practices and more resilient against future issues.