Android: Fixes #11292: Fix unable to sync with multiple Nextcloud accounts in different profiles #11674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ookies on Android Note: An alternative, as suggested on the linked issue, might be to allow users to manually delete all cookies (e.g. under advanced settings). This, however, is more complicated (may require either Android-specific native code or adding a library).
…v-sync-with-multiple-accounts
Comment on lines
+381
to
+389
| if (shim.mobilePlatform() === 'android') { | ||
| // Using credentials = 'omit' prevents authentication cookies from | ||
| // being stored. React Native has issues related to cookie authentication: | ||
| // https://github.com/facebook/react-native/issues/23185 | ||
| // | ||
| // Auth tokens are passed through the "Authorization" header, so | ||
| // these cookies should not be necessary. | ||
| fetchOptions.credentials = 'omit'; | ||
| } |
There was a problem hiding this comment.
Note: This logic is in WebDavApi.js. As such, this currently affects all WebDAV sync targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #11292 by setting preventing React Native from storing cookies when syncing to Nextcloud (see the React Native issue.
Testing plan
Nextcloud 1andNextcloud 2.Nextcloud 2with a Nextcloud account.Nextcloud 1and set up sync with a Nextcloud account on the same domain asNextcloud 2.Nextcloud 2.