Desktop: Fixes #10023: Beta editor plugins: Fix opening and closing settings can break some plugins with legacy code #10024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue where opening and closing settings could break some legacy plugins. A similar change was also made as a part of #9928.
Fixes #10023.
Testing
Follow reproduction steps in #10023:
packages/app-cli/tests/support/plugins/codemirror6/
) as a development plugin.:underline
from the command palette works.:underline
from the command palette still works.This has been tested successfully on Ubuntu 23.10.