Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't open file directly from resources directory #618

Closed
laurent22 opened this issue Jun 14, 2018 · 5 comments
Closed

Don't open file directly from resources directory #618

laurent22 opened this issue Jun 14, 2018 · 5 comments
Labels
enhancement Feature requests and code enhancements stale An issue that hasn't been active for a while...

Comments

@laurent22
Copy link
Owner

Instead copy them to a temp dir and rename them correctly.

#570 (comment)

@laurent22 laurent22 added the enhancement Feature requests and code enhancements label Jun 14, 2018
@armaccloud
Copy link

Hi @laurent22
The current option to open a file allows for editing of the file which is saved in the resources folder.
Wouldn't this change (copying to a temp dir) remove that capability?

@laurent22
Copy link
Owner Author

@armaccloud, yes it would but currently it's not recommended to modify files in the resources folder because they aren't synced afterwards, and they might be overwritten. Basically modifying resources is not supported at the moment. It might at a later time though (there's an open issue about it).

@moltenform
Copy link
Contributor

To clarify, is this talking about opening a resource by clicking the link in the view pane? (For example, dragging a .txt file into a note so that it becomes a resource, and then going to the view pane and clicking on the blue link, which opens the txt file in an external editor).

I can see why this would be a good idea, because of possible perceived data loss after editing, but on the other hand, the instant opening speed on attached files was one of the reasons I moved some of my notebooks from OneNote to Joplin, so it'd be unfortunate if opening resources was slower...

@stale
Copy link

stale bot commented Sep 22, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Sep 22, 2019
@stale
Copy link

stale bot commented Sep 29, 2019

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Sep 29, 2019
@lock lock bot locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Feature requests and code enhancements stale An issue that hasn't been active for a while...
Projects
None yet
Development

No branches or pull requests

4 participants