-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 issues with attached resources #1492
Comments
@laurent22 is this a regression or was this functionality removed intentionally? If the latter, we could close this. |
It was always working as you described. |
In that case I'm afraid we have a regression that crept in at one point. |
I don't think so. The filename has always be HASH.jpg and double-click on images has never been implemented as far as I remember. |
It seems I misunderstood your previous statement then. But I really think both worked at one point. I even opened an issue about a PDF file having the hash instead of the name. And then it was fixed and it showed the filename. |
you both are having a deja vu 😆 And there's this post in the forums, but I couldn't find the exact issue you were referring to. |
Yes, you are right. But I also thought that item 2 had been fixed at one point. I really remember a commit that fixed this, but maybe I'm mixing this up with opening a PDF file (local link, not an attachment)... So I guess we can close this issue as duplicate in favor of #618. @laurent22 what do you think? |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "backlog" and I will leave it open. Thank you for your contributions. |
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information. |
Operating system
Application
I have noticed 2 problems with attached resources, although I think to remember that these things worked in the past.
Steps to reproduce:
attach an image called
test.jpg
open...
- image opens, but does not showtest.jpg
as the name, but<hash>.jpg
Tested with git master on macOS 10.14.4.
The text was updated successfully, but these errors were encountered: