Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 issues with attached resources #1492

Closed
tessus opened this issue May 5, 2019 · 9 comments
Closed

2 issues with attached resources #1492

tessus opened this issue May 5, 2019 · 9 comments
Labels
desktop All desktop platforms stale An issue that hasn't been active for a while...

Comments

@tessus
Copy link
Collaborator

tessus commented May 5, 2019

Operating system

  • Windows
  • macOS
  • Linux

Application

  • Desktop

I have noticed 2 problems with attached resources, although I think to remember that these things worked in the past.

Steps to reproduce:

attach an image called test.jpg

  1. double click on the image in the preview pane - nothing happens
  2. right click on the image in the preview pane and select open... - image opens, but does not show test.jpg as the name, but <hash>.jpg

Tested with git master on macOS 10.14.4.

@tessus
Copy link
Collaborator Author

tessus commented May 13, 2019

@laurent22 is this a regression or was this functionality removed intentionally? If the latter, we could close this.

@laurent22
Copy link
Owner

It was always working as you described.

@tessus
Copy link
Collaborator Author

tessus commented May 14, 2019

In that case I'm afraid we have a regression that crept in at one point.

@laurent22
Copy link
Owner

I don't think so. The filename has always be HASH.jpg and double-click on images has never been implemented as far as I remember.

@tessus
Copy link
Collaborator Author

tessus commented May 14, 2019

It seems I misunderstood your previous statement then.

But I really think both worked at one point. I even opened an issue about a PDF file having the hash instead of the name. And then it was fixed and it showed the filename.
I will search for these issues and try to find the code changes that fixed them.

@tessus tessus added the desktop All desktop platforms label May 18, 2019
@innocuo
Copy link
Contributor

innocuo commented May 24, 2019

you both are having a deja vu 😆
this is a duplicate of #570, almost the same conversation, too.
There's issue #618 about opening files with the right name, in a temp folder.

And there's this post in the forums, but I couldn't find the exact issue you were referring to.

@tessus
Copy link
Collaborator Author

tessus commented May 25, 2019

Yes, you are right. But I also thought that item 2 had been fixed at one point. I really remember a commit that fixed this, but maybe I'm mixing this up with opening a PDF file (local link, not an attachment)...

So I guess we can close this issue as duplicate in favor of #618. @laurent22 what do you think?

@stale
Copy link

stale bot commented Sep 21, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Sep 21, 2019
@stale
Copy link

stale bot commented Sep 29, 2019

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Sep 29, 2019
@lock lock bot locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
desktop All desktop platforms stale An issue that hasn't been active for a while...
Projects
None yet
Development

No branches or pull requests

3 participants