Fix not being allowed to disable shortcuts

laurent22 · Aug 28, 2020 · 989b3d2 · 989b3d2
1 parent bc36748
commit 989b3d2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/ElectronClient/gui/KeymapConfig/KeymapConfigScreen.tsx b/ElectronClient/gui/KeymapConfig/KeymapConfigScreen.tsx
@@ -62,7 +62,9 @@ export const KeymapConfigScreen = ({ themeId }: KeymapConfigScreenProps) => {
 			return (recorderError && <i className="fa fa-exclamation-triangle" />);
 		} else if (hovering[commandName]) {
 			return (<i className="fa fa-pen" />);
-		} else { return null; }
+		} else {
+			return null;
+		}
 	};
 
 	const renderError = (error: KeymapError) => {
@@ -89,7 +91,7 @@ export const KeymapConfigScreen = ({ themeId }: KeymapConfigScreenProps) => {
 						onReset={handleReset}
 						onCancel={handleCancel}
 						onError={handleError}
-						initialAccelerator={accelerator}
+						initialAccelerator={accelerator || ''}
 						commandName={command}
 						themeId={themeId}
 					/> :

diff --git a/ElectronClient/gui/KeymapConfig/ShortcutRecorder.tsx b/ElectronClient/gui/KeymapConfig/ShortcutRecorder.tsx
@@ -25,8 +25,11 @@ export const ShortcutRecorder = ({ onSave, onReset, onCancel, onError, initialAc
 
 	useEffect(() => {
 		try {
-			keymapService.validateAccelerator(accelerator);
-			keymapService.validateKeymap({ accelerator, command: commandName });
+			if (accelerator) {
+				keymapService.validateAccelerator(accelerator);
+				keymapService.validateKeymap({ accelerator, command: commandName });
+			}
+
 			// Discard previous errors
 			onError({ recorderError: null });
 			setSaveAllowed(true);