fix: Remove invalid conditions from persistent tests #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
commented
Jan 3, 2025
Comment on lines
-577
to
-580
| h.RequireNever(t, | ||
| checkForUpdatedValue(t, client, "flag-key", context, | ||
| ldvalue.String("value"), ldvalue.String("new-value"), ldvalue.String("default")), | ||
| time.Millisecond*500, time.Millisecond*20, "flag-key was incorrectly updated") |
There was a problem hiding this comment.
The diff looks weird, but basically the first two if / else if blocks are reduced to this single check.
In FDv2, if the data system has a data source that has provided data, we never rely on the persistent store again. As a result, the "But since ..." checks weren't valid.
| } | ||
| }) | ||
|
|
||
| s.runWithEmptyStore(t, "ignores dropped flags", func(t *ldtest.T) { |
There was a problem hiding this comment.
This is redundant with the check above. Whether I delete flags or change them, it is confirming the same thing.
tanderson-ld
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.