fix: Allow for more flexible flag key in tombstone #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
commented
Nov 4, 2024
| @@ -143,7 +143,7 @@ func newServerSidePersistentTests( | |||
| } | |||
|
|
|||
| func (s *ServerSidePersistentTests) Run(t *ldtest.T) { | |||
| t.Run("uses default prefix", func(t *ldtest.T) { | |||
| s.runWithEmptyStore(t, "uses default prefix", func(t *ldtest.T) { | |||
There was a problem hiding this comment.
This was an issue I noticed when running the tests against a different local service, so I'm adding that on here.
| return m.AllOf( | ||
| m.JSONProperty("key").Should(m.Equal("$deleted")), | ||
| m.AnyOf( | ||
| m.JSONProperty("key").Should(m.Equal(key)), |
There was a problem hiding this comment.
I'm throwing this up here because it was quick to implement, but we should stop and decide if we actually want this.
Should we update each integration to require that the key, when deleted, is updated to $deleted?
kinyoklion
approved these changes
Nov 6, 2024
keelerm84
pushed a commit
that referenced
this pull request
Nov 6, 2024
🤖 I have created a release *beep* *boop* --- ## [2.25.1](v2.25.0...v2.25.1) (2024-11-06) ### Bug Fixes * Allow for more flexible flag key in tombstone ([#256](#256)) ([2a0e8e7](2a0e8e7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.