chore: Add structure to automatically reset between test runs #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
reviewed
Oct 24, 2024
| // Historically, tests in this repository have suffered from onion-like | ||
| // nesting. The further you have to dig, the more you cry. | ||
| // | ||
| // In the time honored tradition of every other language on the planet, we are |
There was a problem hiding this comment.
This was @cwaldren-ld 's prompting. Way to be the change you want to see. 😄
kinyoklion
reviewed
Oct 24, 2024
| h.RequireEventually(t, | ||
| checkForUpdatedValue(t, client, "flag-key", context, | ||
| ldvalue.String("fallthrough"), ldvalue.String("default"), ldvalue.String("default")), | ||
| time.Second, time.Millisecond*20, "flag value was NOT updated after cache TTL") |
There was a problem hiding this comment.
I'm getting mixed messages between the assertion message and the test description.
| DSN: s.persistentStore.DSN(), | ||
| }) | ||
| persistence.SetCache(servicedef.SDKConfigPersistentCache{ | ||
| Mode: servicedef.CacheModeInfinite, |
There was a problem hiding this comment.
Infinite mode isn't a uniform capability. I guess we can suppress the test though.
There was a problem hiding this comment.
That's a good point. I could make it a capability, but it does kind of feel like not supporting infinite is more of a suppression thing. If you can support the other two, seems like you should be able to support this.
kinyoklion
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.