Adjustments based on code review

launchdarkly · Sep 27, 2024 · 230da60 · 230da60
1 parent 9442bf4
commit 230da60
Showing 1 changed file with 8 additions and 17 deletions.
diff --git a/servicedef/sdk_config.go b/servicedef/sdk_config.go
@@ -113,18 +113,9 @@ type SDKConfigDataSystem struct {
 }
 
 type SDKConfigDataSystemDataSource struct {
-	Type string `json:"type"`
-	DataSystemDataSourceConfig
-}
-
-type DataSystemDataSourceConfig interface{}
-
-type DataSystemStreamingDataSourceConfig struct {
-	SDKConfigStreamingParams
-}
-
-type DataSystemPollingDataSourceConfig struct {
-	SDKConfigPollingParams
+	Type      string                            `json:"type"`
+	Streaming o.Maybe[SDKConfigStreamingParams] `json:"streaming,omitempty"`
+	Polling   o.Maybe[SDKConfigPollingParams]   `json:"polling,omitempty"`
 }
 
 type SDKConfigDataSystemPersistence struct {
@@ -135,9 +126,9 @@ type SDKConfigDataSystemPersistence struct {
 type SDKConfigDataSystemPersistenceType string
 
 const (
-	Redis    SDKConfigDataSystemPersistenceType = "redis"
-	DynamoDB SDKConfigDataSystemPersistenceType = "dynamodb"
-	Consul   SDKConfigDataSystemPersistenceType = "consul"
+	Redis    = SDKConfigDataSystemPersistenceType("redis")
+	DynamoDB = SDKConfigDataSystemPersistenceType("dynamodb")
+	Consul   = SDKConfigDataSystemPersistenceType("consul")
 )
 
 type SDKConfigDataSystemPersistenceStore struct {
@@ -154,6 +145,6 @@ const (
 )
 
 type SDKConfigDataSystemPersistenceCache struct {
-	Mode string `json:"mode"`
-	TTL  int    `json:"ttl"` // This value is only valid when the Mode is set to TTL. It must be a positive integer.
+	Mode string       `json:"mode"`
+	TTL  o.Maybe[int] `json:"ttl,omitempty"` // This value is only valid when the Mode is set to TTL. It must be a positive integer.
 }