Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api_key -> sdk_key #69

Merged
merged 5 commits into from
Aug 5, 2016
Merged

api_key -> sdk_key #69

merged 5 commits into from
Aug 5, 2016

Conversation

jkodumal
Copy link
Contributor

@jkodumal jkodumal commented Aug 5, 2016

No description provided.

@drichelson
Copy link
Contributor

We should also switch these occurences:

ag api_key
README.md
29:client = LaunchDarkly::LDClient.new("your_api_key")
39:Rails.configuration.ld_client = LaunchDarkly::LDClient.new("your_api_key")

@drichelson
Copy link
Contributor

and this one:
lib/ldclient-rb/requestor.rb
35: @config.logger.error("[LDClient] Invalid API key")

@drichelson
Copy link
Contributor

👍 once the README.md and requestor.rb strings are changed.

@jkodumal jkodumal merged commit 90b74f2 into v2 Aug 5, 2016
@jkodumal jkodumal deleted the jko/sdk-key branch August 5, 2016 20:05
eli-darkly added a commit that referenced this pull request Jun 26, 2018
@eli-darkly
Merge pull request #69 from launchdarkly/eb/ch19217/http-tests
c66a8e6 
end-to-end tests for new SSE client [2 of 2]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkodumal @drichelson