-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to v2 #67
Update to v2 #67
Conversation
…d all_flags implementations
…t contain a prereq.
@@ -23,246 +24,32 @@ | |||
JSON.parse(data, symbolize_names: true) | |||
end | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests certainly need to be re-added. As part of the refactoring, the client class itself has been broken up pretty substantially, so most of this can be moved to an evaluation_spec.rb
file that tests the evaluation module.
However, I think it's worth reviewing this now-- the tests will be re-added in a follow up PR. This is passing the v2 integration harness so the evaluation part is pretty solid.
👍 |
lambda do |a, b| | ||
(a.is_a? Numeric) && (a >= b) | ||
end, | ||
greaterThanOrEqual: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this duplicated?
reimplement SSE client without Celluloid [1 of 2]
No description provided.