Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increment flag & segment versions when reloading from file data source #285

Merged
merged 1 commit into from
Jun 10, 2024

Commits on Jun 6, 2024

  1. fix: Increment flag & segment versions when reloading from file data …

    …source
    
    The file data source allows specifying flag information as a full flag
    definition, or as a shorted map of flag key:value mappings.
    
    In the case of the flag values, or in the case of a malformed flag
    definition, a flag version might not be specified. When this happens,
    users of the flag tracker will notice an error because the version
    comparison code will encounter an unexpected nil value.
    
    To prevent this from happening, the file data source should be setting a
    version for each flag or segment it reads.
    
    When these items are modified in the LaunchDarkly UI, we automatically
    increment the version associated with the item. To make this easier for
    the user going forward, the file data source will handle incrementing
    this version number each time the file is re-read.
    keelerm84 committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4b90c9e View commit details
    Browse the repository at this point in the history