Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove invalid prereq check_variation_range check #261

Merged
merged 1 commit into from
Mar 28, 2024

Commits on Mar 21, 2024

  1. fix: Remove invalid prereq check_variation_range check

    When parsing flag payload information, the SDK attempts to pre-check
    several failure conditions. One of those conditions was to ensure that a
    provided prereq has a valid variation index.
    
    However, the system cannot actually perform this check at parse time
    since the prerequisite flag might not have been parsed yet.
    
    As this check served only as a nice to have, I have removed it and added
    a test verifying the prereq behavior still operates as expected.
    
    Fixes #260
    keelerm84 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    b2285fc View commit details
    Browse the repository at this point in the history