chore: Add hook support to contract tests #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #237269: Add evaluation-hook capability to contract tests. |
keelerm84
force-pushed
the
mk/sc-237269/hook-tests
branch
from
bdeea90
to
2bf50de
Compare
keelerm84
force-pushed
the
mk/sc-237269/hook-tests
branch
from
2bf50de
to
7a62bac
Compare
cwaldren-ld
reviewed
Mar 21, 2024
contract-tests/hook.rb
Outdated
| payload = { | ||
| evaluationHookContext: { | ||
| flagKey: hook_context.key, | ||
| context: @context_filter.filter(hook_context.context), |
There was a problem hiding this comment.
Why the filtered context?
There was a problem hiding this comment.
The SDK has no other way of converting a context into a hash other than attribute redaction. We haven't needed it yet, and unless the tests require some special handling of private attributes (which seems odd), I figured I could get away with this.
|
(latest updates to the contract test PR) |
Thanks. Updated! |
cwaldren-ld
approved these changes
Mar 28, 2024
keelerm84
added a commit
that referenced
this pull request
Apr 3, 2024
keelerm84
added a commit
that referenced
this pull request
Apr 4, 2024
keelerm84
added a commit
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.