Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare 5.6.1 release #145

Merged
merged 231 commits into from
Jan 7, 2020
Merged

prepare 5.6.1 release #145

merged 231 commits into from
Jan 7, 2020

Conversation

LaunchDarklyCI
Copy link
Contributor

[5.6.1] - 2020-01-06

Fixed:

  • In rare circumstances (depending on the exact data in the flag configuration, the flag's salt value, and the user properties), a percentage rollout could fail and return a default value, logging the error "Data inconsistency in feature flag ... variation/rollout object with no variation or rollout". This would happen if the user's hashed value fell exactly at the end of the last "bucket" (the last variation defined in the rollout). This has been fixed so that the user will get the last variation.

ashanbrown and others added 30 commits July 23, 2018 17:09
@ashanbrown
Remove @ashanbrown from codeowners
f5092af
@eli-darkly
log exception stacktraces at debug level
fd63b2b
@eli-darkly
re-add minimal unit test
d4be186
@eli-darkly
log exceptions at error level
d73d66c
@eli-darkly
Merge pull request #75 from launchdarkly/eb/ch19339/exception-logging
94c8485 
log exceptions at error level and stacktraces at debug level
@eli-darkly
add new version of all_flags that captures more metadata
ca15234
@eli-darkly
add tests for FeatureFlagsState
ed19523
@eli-darkly
provide as_json method that returns a hash instead of just a string
73f2d89
@eli-darkly
state can be serialized with JSON.generate
ab896b1
@eli-darkly
add $valid
00347c6
@eli-darkly
add ability to filter for only client-side flags
bdac27e
@eli-darkly
Merge pull request #76 from launchdarkly/eb/ch22308/all-flags-state
748b59b 
add new version of all_flags that captures more metadata
@eli-darkly
Merge pull request #77 from launchdarkly/eb/ch12124/client-side-filter
50b3aa5 
add ability to filter for only client-side flags
@eli-darkly
implement evaluation with explanations
cee4c18
@eli-darkly
misc cleanup
d2c2ab8
@eli-darkly
misc cleanup, more error checking
64a00a1
@eli-darkly
don't keep evaluating prerequisites if one fails
46b642b
@eli-darkly
doc comment
855c4e2
@eli-darkly
rename variation to variation_index
a0f002f
@eli-darkly
comment
4ec43db
@eli-darkly
more test coverage, convenience method
9622e01
@eli-darkly
Merge branch 'master' of github.com:launchdarkly/ruby-client
7a453b0
@eli-darkly
Merge branch 'master' of github.com:launchdarkly/ruby-client
88d217e
@eli-darkly
fix event generation for a prerequisite that is off
084d9ea
@eli-darkly
fix private
02b5712
@eli-darkly
Merge pull request #78 from launchdarkly/eb/ch19976/explanations
53e8408 
implement evaluation with explanations
@eli-darkly
Merge pull request #79 from launchdarkly/eb/ch22995/prereq-off
c78db15 
fix event generation for a prerequisite that is off
@eli-darkly
Merge branch 'explanation'
960bb89
@eli-darkly
Merge branch 'master' of github.com:launchdarkly/ruby-client
39d6ad1
@eli-darkly
add option to reduce front-end metadata for untracked flags
8867638
eli-darkly and others added 24 commits July 24, 2019 11:49
@eli-darkly
use YAML.safe_load
c1aeaa3
@eli-darkly
add unit test and temporarily revert fix to demonstrate failure
f8aac44
@eli-darkly
restore fix
8f48060
@eli-darkly
Merge pull request #118 from launchdarkly/eb/ch44118/safe-yaml
b5af713 
fix YAML parsing vulnerability
@eli-darkly
add comment about not using FileDataSource in production
8fa005f
@eli-darkly
Merge pull request #119 from launchdarkly/eb/file-data-warning
6a89b0f 
add comment about not using FileDataSource in production
@LaunchDarklyCI
merge from public after release
c1bcd04
@LaunchDarklyCI
merge from public after release
bb543ad
@eli-darkly
drop events if inbox is full
963e4eb
@eli-darkly
Merge pull request #120 from launchdarkly/eb/ch42975/event-bottleneck
26933ab 
drop events if inbox is full
@LaunchDarklyCI
merge from public after release
039efed
@eli-darkly
Merge branch 'master' into experiment
77acf35 
# Conflicts:
#	lib/ldclient-rb/evaluation.rb
#	lib/ldclient-rb/ldclient.rb
#	spec/ldclient_spec.rb
@eli-darkly
update doc comment for track with metric_value
f0581a0
@eli-darkly
Merge branch 'master' of github.com:launchdarkly/ruby-client
c4c2cc1
@eli-darkly
Merge branch 'master' of github.com:launchdarkly/ruby-server-sdk
c742fda
@eli-darkly
Merge pull request #121 from launchdarkly/eb/ch32304/track-comment
f8622a7 
update doc comment for track with metric_value
@eli-darkly
Merge branch 'master' of github.com:launchdarkly/ruby-server-sdk
162b0fe
@eli-darkly
Merge branch 'master' into experiment
032cd5e
@eli-darkly
Merge branch 'master' of github.com:launchdarkly/ruby-server-sdk
1b25d98 
# Conflicts:
#	Gemfile.lock
@eli-darkly
Merge branch 'master' of github.com:launchdarkly/ruby-server-sdk
e3bd340
@eli-darkly
Merge branch 'master' of github.com:launchdarkly/ruby-server-sdk
db27402
@bwoskow-ld
Merge branch 'master' of github.com:launchdarkly/ruby-server-sdk
62518e4
@eli-darkly
don't let user fall outside of last bucket in rollout
7620721
@eli-darkly
Merge pull request #122 from launchdarkly/eb/ch43307/bucketing-fix
4abded2 
don't let user fall outside of last bucket in rollout
@LaunchDarklyCI LaunchDarklyCI merged commit 6c6e283 into master Jan 7, 2020
@LaunchDarklyCI LaunchDarklyCI deleted the release-5.6.1 branch January 7, 2020 01:53
LaunchDarklyCI pushed a commit that referenced this pull request Jan 26, 2021
@eli-darkly
Merge pull request #145 from launchdarkly/eb/ch98642/revert-intf-rename
d2b5a3c 
revert renames of feature_store & update_processor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsiddique zsiddique zsiddique approved these changes

@bwoskow-ld bwoskow-ld Awaiting requested review from bwoskow-ld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LaunchDarklyCI @zsiddique @ashanbrown @eli-darkly @hroederld @bwoskow-ld