Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare 5.4.0 release #109

Merged
merged 59 commits into from
Nov 3, 2018
Merged

prepare 5.4.0 release #109

merged 59 commits into from
Nov 3, 2018

Conversation

eli-darkly
Copy link
Contributor

[5.4.0] - 2018-11-02

Added:

  • It is now possible to inject feature flags into the client from local JSON or YAML files, replacing the normal LaunchDarkly connection. This would typically be for testing purposes. See file_data_source.rb.

Fixed:

  • When shutting down an LDClient, if in polling mode, the client was using Thread.raise to make the polling thread stop sleeping. Thread.raise can cause unpredictable behavior in a worker thread, so it is no longer used.

ashanbrown and others added 30 commits July 23, 2018 17:09
@ashanbrown
Remove @ashanbrown from codeowners
f5092af
@eli-darkly
log exception stacktraces at debug level
fd63b2b
@eli-darkly
re-add minimal unit test
d4be186
@eli-darkly
log exceptions at error level
d73d66c
@eli-darkly
Merge pull request #75 from launchdarkly/eb/ch19339/exception-logging
94c8485 
log exceptions at error level and stacktraces at debug level
@eli-darkly
add new version of all_flags that captures more metadata
ca15234
@eli-darkly
add tests for FeatureFlagsState
ed19523
@eli-darkly
provide as_json method that returns a hash instead of just a string
73f2d89
@eli-darkly
state can be serialized with JSON.generate
ab896b1
@eli-darkly
add $valid
00347c6
@eli-darkly
add ability to filter for only client-side flags
bdac27e
@eli-darkly
Merge pull request #76 from launchdarkly/eb/ch22308/all-flags-state
748b59b 
add new version of all_flags that captures more metadata
@eli-darkly
Merge pull request #77 from launchdarkly/eb/ch12124/client-side-filter
50b3aa5 
add ability to filter for only client-side flags
@eli-darkly
implement evaluation with explanations
cee4c18
@eli-darkly
misc cleanup
d2c2ab8
@eli-darkly
misc cleanup, more error checking
64a00a1
@eli-darkly
don't keep evaluating prerequisites if one fails
46b642b
@eli-darkly
doc comment
855c4e2
@eli-darkly
rename variation to variation_index
a0f002f
@eli-darkly
comment
4ec43db
@eli-darkly
more test coverage, convenience method
9622e01
@eli-darkly
Merge branch 'master' of github.com:launchdarkly/ruby-client
7a453b0
@eli-darkly
Merge branch 'master' of github.com:launchdarkly/ruby-client
88d217e
@eli-darkly
fix event generation for a prerequisite that is off
084d9ea
@eli-darkly
fix private
02b5712
@eli-darkly
Merge pull request #78 from launchdarkly/eb/ch19976/explanations
53e8408 
implement evaluation with explanations
@eli-darkly
Merge pull request #79 from launchdarkly/eb/ch22995/prereq-off
c78db15 
fix event generation for a prerequisite that is off
@eli-darkly
Merge branch 'explanation'
960bb89
@eli-darkly
Merge branch 'master' of github.com:launchdarkly/ruby-client
39d6ad1
@eli-darkly
add option to reduce front-end metadata for untracked flags
8867638
@eli-darkly
implement file data source
cce8e84
@eli-darkly
add poll interval param, tolerate single file path string, add doc co…
22ebded 
…mments
@eli-darkly
make listen dependency optional
b864390
@eli-darkly
readme
789b5a4
@eli-darkly
fix key handling and client integration, add tests
31a62c5
@eli-darkly
debugging
778cb6d
@eli-darkly
debugging
20dbef2
@eli-darkly
add fallback polling logic, fix tests
f1c00b1
@eli-darkly
rm debugging
198b843
@eli-darkly
debugging
c5d1823
@eli-darkly
debugging
9baffe3
@eli-darkly
debugging
4d81215
@eli-darkly
debugging
30d0cd2
@eli-darkly
comment correction
8cb2ed9
@eli-darkly
documentation
a10f973
@eli-darkly
always use YAML parser
16cf9c0
@eli-darkly
report internal error that shouldn't happen
27d954e
@eli-darkly
add test for multiple files
fd308a9
@eli-darkly
fix duplicate key checking (string vs. symbol problem)
1d016bf
@eli-darkly
Don't use 'listen' in JRuby 9.1
c3e66d3
@eli-darkly
rm debugging
1a36fd8
@eli-darkly
better error handling in poll thread
78ba815
@eli-darkly
Merge pull request #82 from launchdarkly/eb/ch25289/file-source
2d29388 
implement file data source
@eli-darkly
don't use Thread.raise to stop PollingProcessor thread; add test for …
38f534f 
…PollingProcessor.stop
@eli-darkly
Merge pull request #83 from launchdarkly/eb/ch19334/no-thread-raise
4966136 
don't use Thread.raise to stop PollingProcessor thread; add test for PollingProcessor.stop
vlymar
vlymar approved these changes Nov 3, 2018
View reviewed changes
Copy link

@vlymar vlymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eli-darkly eli-darkly merged commit a270b47 into master Nov 3, 2018
eli-darkly added a commit that referenced this pull request Mar 21, 2019
@eli-darkly
Merge pull request #109 from launchdarkly/eb/ch34549/net-http-name-error
9e218c2 
fix missing require for net/http
@eli-darkly eli-darkly deleted the 5.4.0 branch November 6, 2019 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlymar vlymar vlymar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eli-darkly @vlymar @ashanbrown @LaunchDarklyCI