Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby SDK evaluates date conditions as false #220

Closed
zbycz opened this issue Jun 5, 2023 · 3 comments
Closed

Ruby SDK evaluates date conditions as false #220

zbycz opened this issue Jun 5, 2023 · 3 comments
Labels
waiting for feedback Indicates LaunchDarkly is waiting for customer feedback before issue is closed due to staleness.

Comments

@zbycz
Copy link

zbycz commented Jun 5, 2023

Describe the bug
If i create a date condition such as this in LD UI, this library always evaluates it as false. (We also use React JS client which works fine.)

Example of UI:
Screenshot 2023-06-02 at 15 00 04

To reproduce

  1. create a new flag with date condition on attribute. It should evaluate to true (ie. past date)
  2. ask for this condition in Ruby code
  3. observe false

SDK version
7.2.0

Language version, developer tools
ruby 3.2.0
@keelerm84
Copy link
Member

My apologies for the error, and thank you for reporting this. I will update you once I have a resolution for you.

Tracking internally as sc-205433.

@keelerm84
Copy link
Member

@zbycz some quick internal testing seems to indicate this is working as expected.

Can you please show me the context you are trying to evaluate? Are you providing the date in the context in RFC 3339 format or as milliseconds?

Are there additional rules on that flag configuration, or is it solely targeting on that date?

@keelerm84 keelerm84 added the waiting for feedback Indicates LaunchDarkly is waiting for customer feedback before issue is closed due to staleness. label Jun 5, 2023
@zbycz
Copy link
Author

zbycz commented Jun 12, 2023

Hi, after all, it was issue on our side. We really provided the date in Ruby-date instead of miliseconds. Thanks for you help. 👍

@zbycz zbycz closed this as completed Jun 12, 2023
LaunchDarklyReleaseBot pushed a commit that referenced this issue Oct 16, 2023
@keelerm84
Implement segment recursion and cycle detection (#220)
25f1c4f 
Clauses in segment rules are now allowed to reference segments. To
prevent an infinite recursion edge case, we implement a similar cycle
detection mechanism as used on prerequisites.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting for feedback Indicates LaunchDarkly is waiting for customer feedback before issue is closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zbycz @keelerm84