fix: Log warning if provided high client init timeout

launchdarkly · May 8, 2024 · e202138 · e202138
1 parent 629ecb5
commit e202138
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/lib/ldclient-rb/ldclient.rb b/lib/ldclient-rb/ldclient.rb
@@ -124,13 +124,20 @@ def initialize(sdk_key, config = Config.default, wait_for_sec = 5)
       end
 
       ready = @data_source.start
-      if wait_for_sec > 0
-        ok = ready.wait(wait_for_sec)
-        if !ok
-          @config.logger.error { "[LDClient] Timeout encountered waiting for LaunchDarkly client initialization" }
-        elsif !@data_source.initialized?
-          @config.logger.error { "[LDClient] LaunchDarkly client initialization failed" }
-        end
+
+      if wait_for_sec < 0
+        @config.logger.warn { "[LDClient] Instantiated with negative timeout parameter #{wait_for_sec}. Returning immediately." }
+      elsif wait_for_sec > 60
+        @config.logger.warn { "[LDClient] Instantiated with high timeout parameter #{wait_for_sec}." }
+      end
+
+      return unless wait_for_sec > 0
+
+      ok = ready.wait(wait_for_sec)
+      if !ok
+        @config.logger.error { "[LDClient] Timeout encountered waiting for LaunchDarkly client initialization" }
+      elsif !@data_source.initialized?
+        @config.logger.error { "[LDClient] LaunchDarkly client initialization failed" }
       end
     end