identify should not emit events if user key is "" (#181)

launchdarkly · Jan 28, 2022 · 275b005 · 275b005
1 parent 64b2549
commit 275b005
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/ldclient-rb/ldclient.rb b/lib/ldclient-rb/ldclient.rb
@@ -248,8 +248,8 @@ def variation_detail(key, user, default)
     # @return [void]
     #
     def identify(user)
-      if !user || user[:key].nil?
-        @config.logger.warn("Identify called with nil user or nil user key!")
+      if !user || user[:key].nil? || user[:key].empty?
+        @config.logger.warn("Identify called with nil user or empty user key!")
         return
       end
       sanitize_user(user)

diff --git a/spec/ldclient_events_spec.rb b/spec/ldclient_events_spec.rb
@@ -196,13 +196,13 @@ def event_processor(client)
         end
       end
 
-      it "does not send event, and logs warning, if user key is nil" do
+      it "does not send event, and logs warning, if user key is blank" do
         logger = double().as_null_object
 
         with_client(test_config(logger: logger)) do |client|
           expect(event_processor(client)).not_to receive(:add_event)
           expect(logger).to receive(:warn)
-          client.identify({ key: nil })
+          client.identify({ key: "" })
         end
       end
     end