Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare 6.1.0 release #90

Merged
merged 20 commits into from
Jun 18, 2018
Merged

prepare 6.1.0 release #90

merged 20 commits into from
Jun 18, 2018

Conversation

eli-darkly
Copy link
Contributor

[6.1.0] - 2018-06-15

Changed:

  • The client now uses urllib3 for HTTP requests, rather than the requests package. This change was made because requests has a dependency on an LGPL-licensed package, and some of our customers cannot use LGPL code. The networking behavior of the client should be unchanged.
  • The client now treats most HTTP 4xx errors as unrecoverable: that is, after receiving such an error, it will not make any more HTTP requests for the lifetime of the client instance, in effect taking the client offline. This is because such errors indicate either a configuration problem (invalid SDK key) or a bug in the client, which will not resolve without a restart or an upgrade. This does not apply if the error is 400, 408, 429, or any 5xx error.
  • During initialization, if the client receives any of the unrecoverable errors described above, ldclient.get() will return immediately; previously it would continue waiting until a timeout. The is_initialized() method will return false in this case.

@eli-darkly eli-darkly requested a review from ashanbrown June 15, 2018 21:26
@eli-darkly eli-darkly merged commit b4b0359 into master Jun 18, 2018
eli-darkly added a commit that referenced this pull request Jan 31, 2019
@eli-darkly eli-darkly deleted the 6.1.0 branch November 6, 2019 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants