Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send the toggle default value with flag request events #40

Merged
merged 2 commits into from
Feb 2, 2016

Conversation

jkodumal
Copy link
Contributor

@jkodumal jkodumal commented Feb 2, 2016

No description provided.

@apucacao
Copy link

apucacao commented Feb 2, 2016

lgtm

@drichelson
Copy link
Contributor

This change looks very lonely.. is there test coverage to make sure this new field shows up?

@pkaeding
Copy link
Contributor

pkaeding commented Feb 2, 2016

👍

@jkodumal
Copy link
Contributor Author

jkodumal commented Feb 2, 2016

@drichelson thanks for the public shaming on tests. Added :)

jkodumal added a commit that referenced this pull request Feb 2, 2016
Send the toggle default value with flag request events
@jkodumal jkodumal merged commit 7bf786b into master Feb 2, 2016
@jkodumal jkodumal deleted the jko/send-default branch February 2, 2016 23:50
eli-darkly added a commit that referenced this pull request May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants