chore: Fix broken pypi publish action #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [this GitHub issue][1], the `pypa/gh-action-pypi-publish` action cannot be used in nested actions. This commit inlines the usage of this action into the top-level workflows instead. [1]: pypa/gh-action-pypi-publish#299
cwaldren-ld
approved these changes
Nov 22, 2024
webknjaz
reviewed
Dec 8, 2024
| - uses: ./.github/actions/publish | ||
| - name: Publish package distributions to PyPI | ||
| if: ${{ inputs.dry_run == false }} | ||
| uses: pypa/gh-action-pypi-publish@release/v1 |
There was a problem hiding this comment.
FYI, the security recommendation is to have this in a dedicated job and avoid giving elevated OIDC privileges to transitive build dependencies.
webknjaz
reviewed
Dec 8, 2024
| with: | ||
| token: ${{env.PYPI_AUTH_TOKEN}} | ||
| dry_run: ${{ inputs.dry_run }} | ||
| password: ${{env.PYPI_AUTH_TOKEN}} |
There was a problem hiding this comment.
This shouldn't be necessary with OIDC: https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this GitHub issue, the
pypa/gh-action-pypi-publishaction cannot be used in nested actions. This commit inlines the usage
of this action into the top-level workflows instead.