Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Skip empty hosts when processing NO_PROXY variable #309

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: Skip empty hosts when processing NO_PROXY variable #309

merged 1 commit into from
Aug 26, 2024

Conversation

hpelwintervold
Copy link
Contributor

@hpelwintervold hpelwintervold commented Aug 26, 2024 •
edited
Loading

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues
#308

Describe the solution you've provided

Add more checks for empty string while parsing NO_PROXY

Describe alternatives you've considered

N/A

Additional context

Comparison of HTTP_PROXY/NO_PROXY implementations: https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/

@hpelwintervold hpelwintervold requested a review from a team as a code owner August 26, 2024 18:13
@keelerm84 keelerm84 changed the title fix: address issues with empty string in fix: Skip empty hosts when processing NO_PROXY variable Aug 26, 2024
keelerm84
keelerm84 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@keelerm84 keelerm84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you for your contribution! Once the tests run, I'll merge this and get a release cut for you.

@keelerm84 keelerm84 merged commit 82d8117 into launchdarkly:main Aug 26, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
Merged
keelerm84 pushed a commit that referenced this pull request Aug 26, 2024
@github-actions
chore(main): release 9.7.1 (#310)
ec74ff8 
🤖 I have created a release *beep* *boop*
---


##
[9.7.1](9.7.0...9.7.1)
(2024-08-26)


### Bug Fixes

* Skip empty hosts when processing NO_PROXY variable
([#309](#309))
([82d8117](82d8117))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keelerm84 keelerm84 keelerm84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hpelwintervold @keelerm84