Skip to content

feat: Added agent support to SDK #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 22, 2025

Conversation

ctawiah
Copy link
Contributor

@ctawiah ctawiah commented Jun 30, 2025

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Describe the solution you've provided

Provide a clear and concise description of what you expect to happen.

Describe alternatives you've considered

Provide a clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context about the pull request here.

@ctawiah ctawiah marked this pull request as ready for review June 30, 2025 20:54
@ctawiah ctawiah requested a review from a team as a code owner June 30, 2025 20:54
@ctawiah ctawiah requested a review from andrewklatzke June 30, 2025 20:54
@@ -125,6 +125,86 @@ def to_dict(self) -> dict:
}


@dataclass(frozen=True)
class LDAIAgent:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keelerm84 you might chime in on this but I know we talked about dropping the LD prefix from class names if the language supports namespaces. Do we want to make this adjustment to the AI SDK before we release 1.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should probably do that, though in another task at this point. Is that something you want to do, or would you rather I take it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do it

@ctawiah
Copy link
Contributor Author

ctawiah commented Jul 22, 2025

@keelerm84 and @jsonbailey I've pushed some update to the branch, please take a look when you get a chance. Python isnt one of my strong languages so a close review will be appreciated - Cursor agents and I wrote this code together 😄

@@ -125,6 +125,86 @@ def to_dict(self) -> dict:
}


@dataclass(frozen=True)
class LDAIAgent:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should probably do that, though in another task at this point. Is that something you want to do, or would you rather I take it?

@ctawiah ctawiah merged commit df8cc20 into main Jul 22, 2025
11 checks passed
@ctawiah ctawiah deleted the ctawiah/REL-8482/add-agents-support-for-sdk branch July 22, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants