Skip to content

fix: publish step should take rockspec inputs #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2024
Merged

fix: publish step should take rockspec inputs #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a78705
fix: update rockspec arguments to publish and ci steps
cwaldren-ld Feb 7, 2024
3e72114
use raw jq output to remove quotes
cwaldren-ld Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/manual-publish-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Build and Test
uses: ./.github/actions/ci

- name: Build documentation
uses: ./.github/actions/build-docs

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,12 @@ jobs:
ssm_parameter_pairs: '/production/common/releasing/luarocks/token = LUAROCKS_API_TOKEN'
- uses: ./.github/actions/ci
with:
rockspec: ${{ fromJSON(needs.rockspec-info.outputs.info).server }}
rockspec: ${{ fromJSON(needs.rockspec-info.outputs.info).server.rockspec }}
- uses: ./.github/actions/publish
name: Publish server package
with:
dry_run: 'false'
rockspec: ${{ fromJSON(needs.rockspec-info.outputs.info).server }}
rockspec: ${{ fromJSON(needs.rockspec-info.outputs.info).server.rockspec }}

publish-redis:
permissions: # Needed for access to the LuaRocks token
Expand All @@ -100,9 +100,9 @@ jobs:
ssm_parameter_pairs: '/production/common/releasing/luarocks/token = LUAROCKS_API_TOKEN'
- uses: ./.github/actions/ci
with:
rockspec: ${{ fromJSON(needs.rockspec-info.outputs.info).redis }}
rockspec: ${{ fromJSON(needs.rockspec-info.outputs.info).redis.rockspec }}
- uses: ./.github/actions/publish
name: Publish redis package
with:
dry_run: 'false'
rockspec: ${{ fromJSON(needs.rockspec-info.outputs.info).redis }}
rockspec: ${{ fromJSON(needs.rockspec-info.outputs.info).redis.rockspec }}
2 changes: 1 addition & 1 deletion .github/workflows/rockspec-info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Fetch release please manifest
id: manifest
run: |
version=$(jq '."."' < .release-please-manifest.json)
version=$(jq --raw-output '."."' < .release-please-manifest.json)
echo "version=$version" >> $GITHUB_OUTPUT
- name: Construct rockspec package names
id: pkg-info
Expand Down