chore: bump semver dep #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #209876: chore: update semver dep. |
|
What confidence level do we have that this will execute nicely in cloudflare, vercel, akamai? Are the current unit tests sufficiently representative of those environments? |
louis-launchdarkly
previously approved these changes
Jul 17, 2023
kinyoklion
requested changes
Jul 17, 2023
louis-launchdarkly
dismissed
their stale review
Ryan has an open question on this.
dariushar
approved these changes
Jul 18, 2023
LGTM |
ctawiah
approved these changes
Jul 18, 2023
monsagri
approved these changes
Jul 19, 2023
|
Looks good to me from what I can see! |
kinyoklion
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating semver to latest. The reason it was pinned to 7.5.0 was because 7.5.0 introduced require('util') without the node: prefix. This has been fixed in 7.5.1 so we'll update to latest which is 7.5.4.