Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use rfc3339 to decode date from text #3411

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix: Use rfc3339 to decode date from text #3411

merged 1 commit into from
Sep 2, 2024

Conversation

pierre-wehbe
Copy link
Contributor

@pierre-wehbe pierre-wehbe commented Aug 7, 2024 •
edited
Loading

Does your PR solve an issue?

#703 (comment)

Fix inspired by https://github.com/launchbadge/sqlx/pull/1618/files

@pierre-wehbe pierre-wehbe force-pushed the fix/chrono_fixedoffset branch 3 times, most recently from de9eab2 to ca7931a Compare August 7, 2024 07:05
@pierre-wehbe pierre-wehbe mentioned this pull request Aug 7, 2024
Open
@pierre-wehbe pierre-wehbe force-pushed the fix/chrono_fixedoffset branch from ca7931a to 3e9473c Compare August 7, 2024 07:13
@pierre-wehbe pierre-wehbe mentioned this pull request Aug 7, 2024
Open
@pierre-wehbe
Copy link
Contributor Author

@abonander @CommanderStorm Any chance this can be reviewed soon?

@CommanderStorm
Copy link
Contributor

CommanderStorm commented Aug 7, 2024 •
edited
Loading

@pierre-wehbe You opened the PR 11h ago and and are already pinging?
I think you might be having this issue in prod => You know you can override the cargo dependency resolution to point to git

CommanderStorm
CommanderStorm suggested changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk why you tagged me. I am not a maintainer, just a fellow contibutor ^^

Could you attach a testcase here to ensure that no regressions on this can happen in the future (and to ensure that this acutally fixes the issue linked, not doubting that it does):

https://github.com/05storm26/sqlx/blob/c5832d90267e085d420fc6f02de5f429f33e7f7d/tests/postgres/types.rs#L221-L277

@pierre-wehbe
Copy link
Contributor Author

@CommanderStorm Already overwrote the cargo deps. Wasn't sure how to get the PR visibility since no Reviewers were assigned.

@abonander
Copy link
Collaborator

It's generally just me, and I get to it when I get to it.

@abonander abonander merged commit fd80f99 into launchbadge:main Sep 2, 2024
86 checks passed
jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
@pierre-wehbe @jrasanen
fix: Use rfc3339 to decode date from text (launchbadge#3411)
d5e5aeb
jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
@pierre-wehbe @jrasanen
fix: Use rfc3339 to decode date from text (launchbadge#3411)
d60cfad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommanderStorm CommanderStorm CommanderStorm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierre-wehbe @CommanderStorm @abonander