-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow converting AnyConnectOptions to a specific ConnectOptions #1610
Conversation
d37aed2
to
9665110
Compare
This is a decent approach, but in addition I think we could stand to have, e.g.: impl AnyConnectOptions {
pub fn as_postgres(&self) -> Option<&PgConnectOptions> { ... }
pub fn as_postgres_mut(&mut self) -> Option<&mut PgConnectOptions> { ... }
} etc. That could end up being a lot of code, of course, though I would personally use a macro to boil that down. |
This is also done. This requires a new dependency 'paste' which is a macro crate to create new identifiers from macros. |
Yeah, we're fine with |
Can you merge this and do a release? |
@abonander When can you merge this? Is this going to be in 0.6? |
No description provided.