build: allow use by TypeScript projects with `bundler`/`node16` config #2084

tash-2s · 2024-01-02T01:33:29Z

Step 1 of the improvements from Current TypeScript packages setup and improvement suggestion #2051

This pull request enables MUD users with moduleResolution set to bundler or node16 in their tsconfig.json to pass tsc by generating .d.ts files during the build. After this change, users with bundler/node16 config can use MUD packages without being affected by MUD's internal TypeScript setup, as they won't need to use the .ts files of MUD packages.

Problem

Currently, moduleResolution: node10 is the only supported option for using MUD packages, which is not ideal for most users. For example, here is the config I'd like to use:

diff --git a/templates/vanilla/packages/client/tsconfig.json b/templates/vanilla/packages/client/tsconfig.json
index d8bb624b..d740aed8 100644
--- a/templates/vanilla/packages/client/tsconfig.json
+++ b/templates/vanilla/packages/client/tsconfig.json
@@ -1,18 +1,17 @@
 {
   "compilerOptions": {
     "types": ["vite/client"],
-    "target": "ESNext",
+    "target": "esnext",
     "useDefineForClassFields": true,
-    "module": "ESNext",
+    "module": "esnext",
     "lib": ["ESNext", "DOM"],
-    "moduleResolution": "Node",
+    "moduleResolution": "bundler",
     "strict": true,
     "resolveJsonModule": true,
     "isolatedModules": true,
     "esModuleInterop": true,
     "noEmit": true,
-    "skipLibCheck": true,
-    "jsx": "react-jsx"
+    "skipLibCheck": true
   },
   "include": ["src"]
 }
diff --git a/templates/vanilla/packages/contracts/tsconfig.json b/templates/vanilla/packages/contracts/tsconfig.json
index 270db8fd..da0a1f48 100644
--- a/templates/vanilla/packages/contracts/tsconfig.json
+++ b/templates/vanilla/packages/contracts/tsconfig.json
@@ -1,13 +1,13 @@
 // Visit https://aka.ms/tsconfig.json for all config options
 {
   "compilerOptions": {
-    "target": "ES2020",
-    "module": "commonjs",
+    "target": "esnext",
+    "module": "esnext",
     "strict": true,
     "resolveJsonModule": true,
     "esModuleInterop": true,
     "skipLibCheck": true,
     "forceConsistentCasingInFileNames": true,
-    "moduleResolution": "node"
+    "moduleResolution": "bundler"
   }
 }

However, this configuration results in the following error (similar errors also occur in client/):

$ cd templates/vanilla/packages/contracts
$ pnpm tsc --noEmit

mud.config.ts:1:27 - error TS7016: Could not find a declaration file for module '@latticexyz/world/register'. '/Users/t/ghq/github.com/tash-2s/mud/packages/world/dist/ts/register/index.js' implicitly has an 'any' type.
  There are types at '/Users/t/ghq/github.com/tash-2s/mud/templates/vanilla/packages/contracts/node_modules/@latticexyz/world/ts/register/index.ts', but this result could not be resolved when respecting package.json "exports". The '@latticexyz/world' library may need to update its package.json or typings.

1 import { mudConfig } from "@latticexyz/world/register";
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 1 error in mud.config.ts:1

This error occurs because, under the moduleResolution: bundler setting, tsc refers to the package.json exports field of the MUD package to find the .js file but fails to find the corresponding .d.ts file.

This issue can also be confirmed using the @arethetypeswrong/cli tool:

$ cd packages/common && attw --entrypoints . --pack .
...
┌───────────────────┬──────────────────────┐
│                   │ "@latticexyz/common" │
├───────────────────┼──────────────────────┤
│ node10            │ 🟢                   │
├───────────────────┼──────────────────────┤
│ node16 (from CJS) │ ❌ No types          │
├───────────────────┼──────────────────────┤
│ node16 (from ESM) │ ❌ No types          │
├───────────────────┼──────────────────────┤
│ bundler           │ ❌ No types          │
└───────────────────┴──────────────────────┘

Solution

To resolve this, this PR enables the generation of .d.ts files during the build. MUD packages use tsup for TypeScript builds, and simply setting dts: true in tsup.config.ts suffices.

.ts files cannot replace .d.ts files in libraries. Using .ts files as type declarations forces users to align their tsconfig.json with that of the libraries.

The targeted packages are under ./packages/, except for:

Empty packages: ecs-browser, network, solecs, std-client, std-contracts, store-cache
Packages with no exports: create-mud
Packages with exports but empty files: cli, store-indexer
Packages not imported from TypeScript: solhint-config-mud, solhint-plugin-mud

With this change, the previously mentioned errors are resolved, and the project works without issues. In projects configured with bundler or node16, tsc no longer asks for the installation of libraries like @types/prettier and @types/react-dom. Additionally, tsc --noEmit time decreased from 13 seconds to 4 seconds under templates/vanilla/packages/client on my mac, as tsc does not need to process MUD's .ts files.

@arethetypeswrong/cli outputs results like this for the packages:

┌───────────────────┬──────────────────────────────┐
│                   │ "@latticexyz/common"         │
├───────────────────┼──────────────────────────────┤
│ node10            │ 🟢                           │
├───────────────────┼──────────────────────────────┤
│ node16 (from CJS) │ ⚠️ ESM (dynamic import only) │
├───────────────────┼──────────────────────────────┤
│ node16 (from ESM) │ 🟢 (ESM)                     │
├───────────────────┼──────────────────────────────┤
│ bundler           │ 🟢                           │
└───────────────────┴──────────────────────────────┘

(MUD packages are pure ESM and are not expected to be used from CJS.)

This change does not impact existing users with node10, as their tsc does not refer to the exports fields in MUD packages, and the built .js files within MUD packages, used by their bundlers, remain unchanged.

The downside is an increase in build time. However, it is not significant, as tsup generates .js and .d.ts files in parallel. Here is a comparison on my mac between the main branch and this branch using a build command that disables all cache: git clean -d -f -x -q && pnpm install && time pnpm build --force.

Main branch (dts disabled):

 Tasks:    24 successful, 24 total
Cached:    0 cached, 24 total
  Time:    1m7.039s 

pnpm build --force  82.02s user 6.78s system 131% cpu 1:07.78 total

This branch (dts enabled):

 Tasks:    24 successful, 24 total
Cached:    0 cached, 24 total
  Time:    1m38.516s 

pnpm build --force  212.04s user 13.61s system 227% cpu 1:39.27 total

Before this change: ``` $ cd packages/dev-tools $ pnpm tsc --declaration src/router.tsx:12:14 - error TS2742: The inferred type of 'router' cannot be named without a reference to '.pnpm/@remix-run+router@1.6.0/node_modules/@remix-run/router'. This is likely not portable. A type annotation is necessary. 12 export const router = createMemoryRouter( ~~~~~~ Found 1 error in src/router.tsx:12 ```

Without this change, error on tsup: ``` Error: namespace must have a "ModuleBlock" body. > 1 | declare module "prettier-plugin-solidity"; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```

changeset-bot · 2024-01-02T01:33:33Z

🦋 Changeset detected

Latest commit: 257e2f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
@latticexyz/abi-ts	Patch
@latticexyz/block-logs-stream	Patch
@latticexyz/common	Patch
@latticexyz/config	Patch
@latticexyz/dev-tools	Patch
@latticexyz/faucet	Patch
@latticexyz/gas-report	Patch
@latticexyz/noise	Patch
@latticexyz/phaserx	Patch
@latticexyz/protocol-parser	Patch
@latticexyz/react	Patch
@latticexyz/recs	Patch
@latticexyz/schema-type	Patch
@latticexyz/services	Patch
@latticexyz/store-sync	Patch
@latticexyz/store	Patch
@latticexyz/utils	Patch
@latticexyz/world-modules	Patch
@latticexyz/world	Patch
@latticexyz/cli	Patch
@latticexyz/store-indexer	Patch
create-mud	Patch
@latticexyz/ecs-browser	Patch
@latticexyz/network	Patch
@latticexyz/solecs	Patch
solhint-config-mud	Patch
solhint-plugin-mud	Patch
@latticexyz/std-client	Patch
@latticexyz/std-contracts	Patch
@latticexyz/store-cache	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tash-2s · 2024-01-02T01:36:00Z

packages/common/src/codegen/modules.d.ts

@@ -1 +1 @@
-declare module "prettier-plugin-solidity";
+declare module "prettier-plugin-solidity" {}


The tsup's internal dts generation process doesn't support the original syntax, so I've changed it to a format that both tsc and tsup accept. There is no change in meaning in this context. Without this, the following error occurs on tsup:

Error: namespace must have a "ModuleBlock" body. > 1 | declare module "prettier-plugin-solidity"; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

holic · 2024-01-02T10:16:33Z

With this change, the previously mentioned errors are resolved, and the project works without issues. In projects configured with bundler or node16, tsc no longer asks for the installation of libraries like @types/prettier and @types/react-dom. Additionally, tsc --noEmit time decreased from 13 seconds to 4 seconds under templates/vanilla/packages/client on my mac, as tsc does not need to process MUD's .ts files.

💯 🎉

holic · 2024-01-02T10:17:39Z

Thank you! CI looks happy, so I'm gonna merge this.

Is there anything CI-wise we should wire up to ensure we can keep this level of compatibility?

tash-2s · 2024-01-02T19:22:48Z

Is there anything CI-wise we should wire up to ensure we can keep this level of compatibility?

Good point. We should ensure CI covers all supported user environments to avoid accidentally breaking compatibility, so I should add a test for non-node10 tsconfig settings. I'll write this task in the original issue.

tash-2s added 3 commits January 1, 2024 13:00

build: enable .d.ts files generation

dcffc8f

build(common): fix for tsup dts generation

3efed72

Without this change, error on tsup: ``` Error: namespace must have a "ModuleBlock" body. > 1 | declare module "prettier-plugin-solidity"; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```

tash-2s requested review from alvrs and holic as code owners January 2, 2024 01:33

tash-2s commented Jan 2, 2024

View reviewed changes

Create poor-beans-beg.md

257e2f9

holic merged commit 5905420 into latticexyz:main Jan 2, 2024
10 of 11 checks passed

holic mentioned this pull request Jan 2, 2024

fix(templates): fix templates tsc errors and add test #2036

Merged

tash-2s mentioned this pull request Jan 2, 2024

Current TypeScript packages setup and improvement suggestion #2051

Closed

tash-2s deleted the typescript-setup-improvement-step-1 branch January 2, 2024 19:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: allow use by TypeScript projects with `bundler`/`node16` config #2084

build: allow use by TypeScript projects with `bundler`/`node16` config #2084

tash-2s commented Jan 2, 2024

changeset-bot bot commented Jan 2, 2024 •

edited

Loading

tash-2s Jan 2, 2024

holic commented Jan 2, 2024

holic commented Jan 2, 2024

tash-2s commented Jan 2, 2024

		@@ -1 +1 @@
		declare module "prettier-plugin-solidity";
		declare module "prettier-plugin-solidity" {}

build: allow use by TypeScript projects with bundler/node16 config #2084

build: allow use by TypeScript projects with bundler/node16 config #2084

Conversation

tash-2s commented Jan 2, 2024

Problem

Solution

changeset-bot bot commented Jan 2, 2024 • edited Loading

🦋 Changeset detected

tash-2s Jan 2, 2024

Choose a reason for hiding this comment

holic commented Jan 2, 2024

holic commented Jan 2, 2024

tash-2s commented Jan 2, 2024

build: allow use by TypeScript projects with `bundler`/`node16` config #2084

build: allow use by TypeScript projects with `bundler`/`node16` config #2084

changeset-bot bot commented Jan 2, 2024 •

edited

Loading