Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev-tools): update actions to display function name instead of callFrom #1497

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

y77cao
Copy link
Contributor

@y77cao y77cao commented Sep 15, 2023

Follow up for #1466

Before:
Screenshot 2023-09-14 at 9 45 53 PM
After
Screenshot 2023-09-14 at 9 42 26 PM

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023

🦋 Changeset detected

Latest commit: d95ee48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@latticexyz/dev-tools Major
@latticexyz/abi-ts Major
@latticexyz/block-logs-stream Major
@latticexyz/cli Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/react Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/store-indexer Major
@latticexyz/store-sync Major
@latticexyz/store Major
@latticexyz/utils Major
@latticexyz/world Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@y77cao y77cao changed the title feat(dev-tools): Update actions to display function name instead of callFrom feat(dev-tools): update actions to display function name instead of callFrom Sep 18, 2023
@holic holic marked this pull request as ready for review September 18, 2023 14:16
holic
holic previously approved these changes Sep 18, 2023
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

My comment above isn't blocking. If you do decide to commit that, it might need a pass through prettier because I just typed it into GitHub and no idea if I got the formatting correct.

@holic
Copy link
Member

holic commented Sep 18, 2023

just realized we can actually land this independent of #1466, and sky strife would get immediate benefit from this (they already use callFrom internally)

@y77cao y77cao force-pushed the y77cao/devtool-replace-callfrom branch from 8d86eb6 to 2beb30b Compare September 18, 2023 15:28
@y77cao y77cao changed the base branch from y77cao/call-from to main September 18, 2023 15:28
@y77cao y77cao dismissed holic’s stale review September 18, 2023 15:28

The base branch was changed.

@y77cao y77cao removed the request for review from dk1a September 18, 2023 15:29
holic
holic previously approved these changes Sep 18, 2023
@holic holic merged commit 24a0dd4 into main Sep 18, 2023
5 of 9 checks passed
@holic holic deleted the y77cao/devtool-replace-callfrom branch September 18, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants