fix(world): register Delegations table in CoreModule #1452
Conversation
🦋 Changeset detectedLatest commit: 53b9b0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -58,6 +59,7 @@ contract CoreModule is IModule, WorldContextConsumer { | |||
| */ | |||
| function _registerCoreTables() internal { | |||
| InstalledModules.register(); | |||
| Delegations.register(); | |||
There was a problem hiding this comment.
any easy way to add some tests to ensure we're registering all of our expected core tables?
There was a problem hiding this comment.
no automated way, maintaining the test would have the same issue as maintaining the actual registration
There was a problem hiding this comment.
well we could add some sort of e2e test that checks that all tables in the world config are registered, but for that we first need to separate the test tables
There was a problem hiding this comment.
opened an issue to track here: #1456
small patch to register the Delegations table so it can be synced by the sync stack