Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin foundry to fix issues in test running an anvil node #1372

Closed
wants to merge 10 commits into from

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Aug 30, 2023

  • Tests are suddenly failing on new PRs without related changes. The purpose of this PR is to investigate the reason.

See https://github.com/latticexyz/mud/actions/runs/6025236361/job/16345515615#step:9:45
CleanShot 2023-08-30 at 15 08 17@2x

Edit: fixed by pinning foundry to bff4ed912bb023d7bf9b20eda581aa4867a1cf70, see foundry-rs/foundry#5749

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2023

⚠️ No Changeset found

Latest commit: 3d2c1cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alvrs alvrs changed the title test: fix CI actions ci: pin foundry to fix issues in test running an anvil node Aug 30, 2023
@alvrs
Copy link
Member Author

alvrs commented Aug 30, 2023

dk1a
dk1a previously approved these changes Aug 30, 2023
@alvrs
Copy link
Member Author

alvrs commented Aug 31, 2023

Closing this since the issue has been fixed upstream and no pinning is necessary anymore

@alvrs alvrs closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants