Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): make mud test exit with code 1 on test error #1371

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Aug 30, 2023

  • Currently the process always exits with code 0, so CIs can't detect the script failure. Now the script exits with code 1 in case of an error.

@alvrs alvrs requested a review from holic as a code owner August 30, 2023 12:54
@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2023

🦋 Changeset detected

Latest commit: ae545eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@latticexyz/cli Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/ecs-browser Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alvrs
Copy link
Member Author

alvrs commented Aug 30, 2023

@alvrs
Copy link
Member Author

alvrs commented Aug 30, 2023

dk1a
dk1a previously approved these changes Aug 31, 2023
@alvrs alvrs changed the base branch from alvrs/empty-commit to main August 31, 2023 13:18
@alvrs alvrs dismissed dk1a’s stale review August 31, 2023 13:18

The base branch was changed.

@alvrs
Copy link
Member Author

alvrs commented Aug 31, 2023

merging since no code change since last approval

@alvrs alvrs merged commit dc258e6 into main Aug 31, 2023
9 checks passed
@alvrs alvrs deleted the alvrs/fix-ci-test-action branch August 31, 2023 13:34
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants