Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-mud): infer recs components from config #1278

Merged
merged 11 commits into from
Aug 11, 2023

Conversation

holic
Copy link
Member

@holic holic commented Aug 10, 2023

  • creates components from config
  • infers TS types for components from config
  • removes all related codegen

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2023

🦋 Changeset detected

Latest commit: 55ea766

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@latticexyz/cli Major
@latticexyz/std-client Major
@latticexyz/store-sync Major
@latticexyz/store Major
@latticexyz/world Major
create-mud Major
@latticexyz/dev-tools Major
@latticexyz/ecs-browser Major
@latticexyz/store-indexer Major
@latticexyz/network Major
@latticexyz/react Major
@latticexyz/store-cache Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
@latticexyz/gas-report Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-contracts Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review August 10, 2023 11:02
@holic holic requested a review from alvrs as a code owner August 10, 2023 11:02
@@ -14,5 +14,5 @@
"skipLibCheck": true,
"jsx": "react-jsx"
},
"include": ["src"]
"include": ["src", "../store-sync/src/recs/common.test-d.ts"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for context, why is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, this got added by vscode after a rename

},
{
componentName: "StoreMetadata";
// TODO: fix config namespace so it comes back as a const
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should keep this in mind for #994

packages/store/ts/common.ts Outdated Show resolved Hide resolved
alvrs
alvrs previously approved these changes Aug 11, 2023
Co-authored-by: alvarius <alvarius@lattice.xyz>
@holic holic merged commit 48c51b5 into main Aug 11, 2023
9 checks passed
@holic holic deleted the holic/recs-components-from-config branch August 11, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants