feat(store-indexer): return a "not found" error when no snapshot is f…

…ound for a `/api/logs` request (#2043)
latticexyz · Dec 8, 2023 · f61b4bc · f61b4bc
1 parent 85b9461
commit f61b4bc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/yellow-bags-learn.md b/.changeset/yellow-bags-learn.md
@@ -0,0 +1,5 @@
+---
+"@latticexyz/store-indexer": minor
+---
+
+The `/api/logs` indexer endpoint is now returning a `404` snapshot not found error when no snapshot is found for the provided filter instead of an empty `200` response.
diff --git a/packages/store-indexer/src/postgres/apiRoutes.ts b/packages/store-indexer/src/postgres/apiRoutes.ts
@@ -32,8 +32,15 @@ export function apiRoutes(database: Sql): Middleware {
       benchmark("query records");
       const logs = records.map(recordToLog);
       benchmark("map records to logs");
-      const blockNumber = records[0]?.chainBlockNumber ?? "-1";
 
+      if (records.length === 0) {
+        ctx.status = 404;
+        ctx.body = "no logs found";
+        debug(`no logs found for chainId ${options.chainId}, address ${options.address}, filters ${options.filters}`);
+        return;
+      }
+
+      const blockNumber = records[0].chainBlockNumber;
       ctx.body = JSON.stringify({ blockNumber, logs });
       ctx.status = 200;
     } catch (error) {