Only write to the rawBucket if the value exists. (ossf#2451)

Signed-off-by: Caleb Brown <calebbrown@google.com> Signed-off-by: Caleb Brown <calebbrown@google.com> Signed-off-by: latortuga71 <christopheralonso1@gmail.com>
latortuga71 · Nov 18, 2022 · ca0d1e2 · ca0d1e2
1 parent 49e9418
commit ca0d1e2
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/cron/internal/controller/main.go b/cron/internal/controller/main.go
@@ -168,14 +168,16 @@ func main() {
 		panic(fmt.Errorf("error writing to BlobStore: %w", err))
 	}
 
-	// Raw data.
-	*metadata.ShardLoc = rawBucket + "/" + data.GetBlobFilename("", t)
-	metadataJSON, err = protojson.Marshal(&metadata)
-	if err != nil {
-		panic(fmt.Errorf("error during protojson.Marshal raw: %w", err))
-	}
-	err = data.WriteToBlobStore(ctx, rawBucket, data.GetShardMetadataFilename(t), metadataJSON)
-	if err != nil {
-		panic(fmt.Errorf("error writing to BlobStore raw: %w", err))
+	if rawBucket != "" {
+		// Raw data.
+		*metadata.ShardLoc = rawBucket + "/" + data.GetBlobFilename("", t)
+		metadataJSON, err = protojson.Marshal(&metadata)
+		if err != nil {
+			panic(fmt.Errorf("error during protojson.Marshal raw: %w", err))
+		}
+		err = data.WriteToBlobStore(ctx, rawBucket, data.GetShardMetadataFilename(t), metadataJSON)
+		if err != nil {
+			panic(fmt.Errorf("error writing to BlobStore raw: %w", err))
+		}
 	}
 }